Wrong Example in SplFixedArray docs

[abdelrahman-gado]

From manual page: https://php.net/class.splfixedarray

---

In the example of SplFixedArray Example #1 SplFixedArray usage example, you state that the following code will give RuntimeException but what it is actually throws is TypeError. So, the catch part will never executed.

// The following lines throw a RuntimeException: Index invalid or out of range
try {
    var_dump($array["non-numeric"]);
} catch(RuntimeException $re) {
    echo "RuntimeException: ".$re->getMessage()."\n";
}

[cmb69]

Oh, indeed there's no more RuntimeException as of PHP 8.1.0 (https://3v4l.org/sdIQd). That example needs to be fixed (but should somehow address the version dependent behavior).

[nielsdos]

Quick thinking: change RuntimeException to Throwable in the example code and that would work. (and change the echo statement)

[damianwadley]

The documentation always favors the most recent versions - that's why there are changelog tables. So why not solve this the same way other versioning issues are solved: write it to be valid for 8.3 and add a code comment to the effect of "// throws RuntimeException in PHP 8.0 and earlier"?

Side note: speaking of changelog tables, the offsetGet/Set/Unset docs all say they throw RuntimeException too.

[cmb69]

Actually, I don't think we should tell people to catch TypeErrors (they should fix their code instead). Maybe we should move the var_dump($array["non-numeric"]); to the bottom, commenting that this is a TypeError (but prior to PHP 8.1.0 has been a RuntimeException).

Implementation nit: passing an out of range index still reports "Index invalid or out of range" (https://3v4l.org/GMIMC).