Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Memcached::OPT_NOREPLY #584

Closed
wants to merge 2 commits into from

Conversation

TysonAndre
Copy link
Contributor

This was added in 2009.
A lot of other constants were also added.
See http://docs.libmemcached.org/memcached_behavior.html

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

reference/memcached/constants.xml Outdated Show resolved Hide resolved
reference/memcached/constants.xml Outdated Show resolved Hide resolved
@TysonAndre
Copy link
Contributor Author

A lot of the command documentation elsewhere was based on libmemcached docs, such as http://docs.libmemcached.org/memcached_behavior.html#MEMCACHED_BEHAVIOR_RCV_TIMEOUT - I assume we shouldn't have done this initially, but now that it's already translated, it's too late to change the <literal>boolean</literal> and use of you

@@ -216,6 +216,30 @@
</listitem>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    <para>Enables or disables asynchronous I/O. This is the fastest transport
     available for storage functions.</para>
    <para>Type: <literal>boolean</literal>, default: &false;.</para>

i.e. there'll be a mix of boolean and bool - does the translation system have issues with replacing literals?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not replace literals at all (it's just about the markup).

This was added in 2009.
A lot of other constants were also added.
See http://docs.libmemcached.org/memcached_behavior.html
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to slightly change the wording to better match the rest of the page, and I'm going to change all type markup.

Thanks for the PR! And thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants