Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect linked complexTypes as ResultInterface as well #549

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Sep 27, 2024

Fixes #546 (comment), #550

The ResultAssembler is not able to detect wether an element with linked complexType is being used as the result.
More info: #546

    ->addRule(
        new Rules\IsResultRule(
            $engine->getMetadata(),
            new Rules\MultiRule([
                new Rules\AssembleRule(new Assembler\ResultAssembler()),
            ])
        )
    )

Given

<xs:complexType name="versionResponse">
    <xs:sequence>
        <xs:element minOccurs="0" name="version" type="xs:string" />
    </xs:sequence>
</xs:complexType>
<xs:element name="esfVersionResponse" nillable="true" type="tns:versionResponse"/>

This assembler can now detect that both esfVersionResponse and versionResponse should be marked as ResultInterface.

@rauanmayemir
Copy link

This works. 💃

@veewee veewee merged commit a23f11d into phpro:v4.x Sep 27, 2024
12 checks passed
veewee added a commit to veewee/soap-client that referenced this pull request Sep 27, 2024
Detect linked complexTypes as ResultInterface as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants