test @throws tag

phpstan · Sep 10, 2024 · 1b2037c · 1b2037c
1 parent 227db6c
commit 1b2037c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/Rules/Operators/InvalidBinaryOperationRule.php b/src/Rules/Operators/InvalidBinaryOperationRule.php
@@ -124,6 +124,7 @@ public function processNode(Node $node, Scope $scope): array
  || $node instanceof Node\Expr\BinaryOp\Mod
  )
  && !$this->isDivisionByZeroCaught($node)
+ && !$this->hasDivisionByZeroThrowsTag($scope)
  ) {
  $zeroType = new ConstantIntegerType(0);
  if ($zeroType->isSuperTypeOf($rightType)->maybe()) {
@@ -169,4 +170,19 @@ private function isDivisionByZeroCaught(Node $node): bool
  return $tryCatchType->isSuperTypeOf(new ObjectType(DivisionByZeroError::class))->yes();
  }
 
+ private function hasDivisionByZeroThrowsTag(Scope $scope): bool
+ {
+ $function = $scope->getFunction();
+ if ($function === null) {
+ return false;
+ }
+
+ $throwsType = $function->getThrowType();
+ if ($throwsType === null) {
+ return false;
+ }
+
+ return $throwsType->isSuperTypeOf(new ObjectType(DivisionByZeroError::class))->yes();
+ }
+
 }
diff --git a/tests/PHPStan/Rules/Operators/data/invalid-division.php b/tests/PHPStan/Rules/Operators/data/invalid-division.php
@@ -68,3 +68,9 @@ function (int $i, int $x): void {
  }
 };
 
+/**
+ * @throws \DivisionByZeroError
+ */
+function throws(int $i, int $x) {
+ return $i / $x;
+};