prevent false positive

phpstan · Sep 9, 2024 · f8faf37 · f8faf37
1 parent 1ca86c3
commit f8faf37
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/Parser/TryCatchTypeVisitor.php b/src/Parser/TryCatchTypeVisitor.php
@@ -24,7 +24,14 @@ public function beforeTraverse(array $nodes): ?array
 
  public function enterNode(Node $node): ?Node
  {
- if ($node instanceof Node\Stmt || $node instanceof Node\Expr\Match_) {
+ if (
+ $node instanceof Node\Stmt
+ || $node instanceof Node\Expr\Match_
+ || $node instanceof Node\Expr\AssignOp\Div
+ || $node instanceof Node\Expr\AssignOp\Mod
+ || $node instanceof Node\Expr\BinaryOp\Div
+ || $node instanceof Node\Expr\BinaryOp\Mod
+ ) {
  if (count($this->typeStack) > 0) {
  $node->setAttribute(self::ATTRIBUTE_NAME, $this->typeStack[count($this->typeStack) - 1]);
  }

diff --git a/src/Rules/Operators/InvalidBinaryOperationRule.php b/src/Rules/Operators/InvalidBinaryOperationRule.php
@@ -2,18 +2,23 @@
 
 namespace PHPStan\Rules\Operators;
 
+use DivisionByZeroError;
 use PhpParser\Node;
 use PHPStan\Analyser\MutatingScope;
 use PHPStan\Analyser\Scope;
 use PHPStan\Node\Printer\ExprPrinter;
+use PHPStan\Parser\TryCatchTypeVisitor;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\ErrorType;
+use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
+use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\VerbosityLevel;
+use function array_map;
 use function sprintf;
 use function strlen;
 use function substr;
@@ -118,6 +123,7 @@ public function processNode(Node $node, Scope $scope): array
  || $node instanceof Node\Expr\BinaryOp\Div
  || $node instanceof Node\Expr\BinaryOp\Mod
  )
+ && !$this->isDivisionByZeroCaught($node)
  ) {
  $zeroType = new ConstantIntegerType(0);
  if ($zeroType->isSuperTypeOf($rightType)->maybe()) {
@@ -151,4 +157,16 @@ public function processNode(Node $node, Scope $scope): array
  ];
  }
 
+ private function isDivisionByZeroCaught(Node $node): bool
+ {
+ $tryCatchTypes = $node->getAttribute(TryCatchTypeVisitor::ATTRIBUTE_NAME);
+ if ($tryCatchTypes === null) {
+ return false;
+ }
+
+ $tryCatchType = TypeCombinator::union(...array_map(static fn (string $class) => new ObjectType($class), $tryCatchTypes));
+
+ return $tryCatchType->isSuperTypeOf(new ObjectType(DivisionByZeroError::class))->yes();
+ }
+
 }