Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary FileIO from FileReader #2094

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Remove unnecessary FileIO from FileReader #2094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/File/FileReader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace PHPStan\File;

use function file_get_contents;
use function is_file;
use function stream_resolve_include_path;

class FileReader
Expand All @@ -13,14 +12,17 @@ public static function read(string $fileName): string
{
$path = $fileName;

if (!is_file($path)) {
$contents = @file_get_contents($path);
if ($contents === false) {
$path = stream_resolve_include_path($fileName);

if ($path === false) {
throw new CouldNotReadFileException($fileName);
}

$contents = @file_get_contents($path);
}
$contents = @file_get_contents($path);

if ($contents === false) {
throw new CouldNotReadFileException($fileName);
}
Expand Down