Fix ImpossibleCheckTypeFunctionCallRule for is_subclass_of and is_a
#3404
+168
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing the rule is not going to help you against "Result of && is always false.". I'd much rather change the logic in IsSubclassOfFunctionTypeSpecifyingExtension. |
VincentLanglet
force-pushed
the
fix3979
branch
from
591e804
to
10eb37a
Compare
VincentLanglet
changed the title
is_subclass_ofis_subclass_of and is_a
VincentLanglet
force-pushed
the
fix3979
branch
from
8704421
to
8443ae3
Compare
VincentLanglet
commented
Sep 5, 2024
| @@ -1133,9 +1133,7 @@ public function dataCondition(): iterable | |||
| new Arg(new Variable('stringOrNull')), | |||
| new Arg(new Expr\ConstFetch(new Name('false'))), | |||
| ]), | |||
| [ | |||
| '$object' => 'object', | |||
There was a problem hiding this comment.
if (is_subclass_of($object, $stringOrNull, false))
specified $object as object but this was already known so it's not a big loss.
VincentLanglet
force-pushed
the
fix3979
branch
from
8443ae3
to
8d67889
Compare
|
This pull request has been marked as ready for review. |
I think it was possible indeed, I get something working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#3979
which can be simplified to https://phpstan.org/r/ef72a996-8fbe-4a4e-831f-4d78c542ad19
I'm not sure there is a better (easy ?) fix for this issue.
is_subclass_of($string, $bar)specify the type of$stringto class-string when true, but it doesn't mean that the call is useless if the param is already a class-string.I discovered there was an exclusion of
is_ain theImpossibleCheckTypeFunctionCallRule(maybe for the same reason)so I think it could be the same for
is_subclass_ofsince the behavior is similar.