Support @readonly PHPDoc on the class as alternative to @immutable
#3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x. |
herndlm
force-pushed
the
readonly-class-phpdoc
branch
from
4e1be28
to
cb31b0a
Compare
herndlm
force-pushed
the
readonly-class-phpdoc
branch
2 times, most recently
from
951ab20
to
7b449ed
Compare
herndlm
force-pushed
the
readonly-class-phpdoc
branch
from
7b449ed
to
8d193e4
Compare
|
love it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#11775
Docs PR: phpstan/phpstan#11783
I decided to directly adapt
ClassReflection::isImmutable()because there is alreadyClassReflection::isReadonly()for native readonly and that would clash. An alternative would be to add a newClassReflection::isReadonlyPhpDoc()or so, but I dislike that isImmutable is also PHPDoc only and it then feels somewhat inconsistent / even more complicated :)the rules are still, as before, only enabled with the
readOnlyByPhpDocfeature toggle.