Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Django 4.x #74

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

jwmullally
Copy link

Closes #71 .


Implement simple fixes proposed in #71.

According to the Django documentation here, the kwargs used in signal send() calls in views.py should continue to work as-is, so there should be no impact on the API.

Related: #73

@jwmullally
Copy link
Author

This change is intended to be merged alongside #73 as part of the upcoming v4.0.1 release.

@bioworkflows
Copy link

bioworkflows commented Jun 9, 2023

Please merge this PR since this package is preventing us from upgrading to Django 4.2.x.

Edit: I can confirm that this PR works for Django 4.2.3.

@jwmullally
Copy link
Author

For anyone waiting, a temporary solution is to fork this PR branch to your own Github account, browse the files at this specific commit, The get the link from "Code" -> "Download ZIP" , and include that link in your requirements.txt:

E.g.
https:/<your-account>/pinax-announcements/archive/fce9b50bee2b9e243b0c536eb310cf47d8c72636.zip

@UsamaSadiq
Copy link

@agusmakmun @paltman could we please have this PR merged and new version released to have Django 4.2 support. Thanks.

@agusmakmun
Copy link
Collaborator

Hello @UsamaSadiq, I didn't have access to bump the lastest version to pypi.
Also, this fixes will require another pinax packages changes as well #73

So, need @paltman on it.

@UsamaSadiq
Copy link

Using the temporary fork https:/openedx/pinax-announcements/ for Django 4.2 support until the new version gets released on PyPI.

@agusmakmun agusmakmun merged commit 12a695d into pinax:master Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Django 4.0
4 participants