Adds column-metadata option to Column Family at creation. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. I noticed some mismatch in how we do some conversions which inspired me to create #23 but I don't think there is anything specifically to do here. Are you also planning on adding query capabilities for indexed columns as part of this ticket. If so, we can just include that as part of this pull request. If not we can close this pull request/issue and open a different issue for adding the ability to query the index. |
|
Frankly I was just planning on using CQL for querying secondary indexes. I have not even investigated how to do so with Hector. I may be able to take a look at hector secondary indexes either on Friday or this weekend. It is at your discretion weather you would like that as part of this pull request or not. |
nickmbailey
added a commit
that referenced
this pull request
Apr 11, 2012
Adds column-metadata option to Column Family at creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests could use some more flushing out: there are no tests actually exercising the secondary indexes.
Any feedback would be great!
Ref #21