Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MongoDB 6.4 #160

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

santuman
Copy link

@santuman santuman commented Mar 5, 2024

Updated MongoDB to version 6.4, adjusted MongoClient connection options, and revised README to match. Addresses the punycode deprecation warning and ensures up-to-date compatibility.

Fixes #159

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina changed the title Fix - mongodb punycode warning Update to MongoDB 6.4 Mar 5, 2024
@mcollina
Copy link
Member

mcollina commented Mar 5, 2024

Can you please add Node.js v20 to the test matrix?

@santuman
Copy link
Author

santuman commented Mar 7, 2024

@mcollina Added v20 to the test matrix

@mcollina
Copy link
Member

mcollina commented Mar 7, 2024

This seems to break some Node v14 tests. Can you check it?

@mcollina
Copy link
Member

mcollina commented Mar 7, 2024

We might need to drop v14 and v16.

@santuman
Copy link
Author

santuman commented Mar 7, 2024

The MongoDB v6.4 driver lacks compatibility with Node.js versions beyond v16.x.x
Refer to https://www.mongodb.com/docs/drivers/node/current/compatibility/ for details

We might have to just drop only v14. Test on v16 is getting cancelled

@mcollina
Copy link
Member

mcollina commented Mar 7, 2024

Let's be future proof and drop both.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@santuman
Copy link
Author

The end-to-end test experienced significant delays and was eventually cancelled

@mcollina
Copy link
Member

Can you debug what's the problem and fix them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation Warning from tr46 Package Related to punycode Module
2 participants