Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cli args usage #69

Merged
merged 6 commits into from
Sep 21, 2021
Merged

fix cli args usage #69

merged 6 commits into from
Sep 21, 2021

Conversation

Eomm
Copy link
Contributor

@Eomm Eomm commented Sep 19, 2021

fix #68

@Eomm Eomm force-pushed the cli-args branch 2 times, most recently from 6471da5 to dd0f15c Compare September 19, 2021 13:05
mcollina
mcollina approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm
Copy link
Contributor Author

Eomm commented Sep 20, 2021

The CI fails on node12 because childprocess.kill('SIGINT') does not trigger the event on the spawned process.

Not found the solution at the moment

@mcollina
Copy link
Member

Can we just skip that text on Node v12?

@Eomm
Copy link
Contributor Author

Eomm commented Sep 21, 2021

Increasing the timeout solved

mcollina
mcollina approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 14b9be4 into pinojs:master Sep 21, 2021
@Eomm Eomm deleted the cli-args branch September 21, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using pipe
2 participants
@Eomm @mcollina