Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Carthage for watchOS, dependent by PINCache #31

Merged
merged 2 commits into from
May 21, 2020
Merged

Add Carthage for watchOS, dependent by PINCache #31

merged 2 commits into from
May 21, 2020

Conversation

dreampiggy
Copy link
Contributor

@dreampiggy dreampiggy commented Apr 13, 2020 •
edited
Loading

@dreampiggy dreampiggy mentioned this pull request Apr 13, 2020
Merged
@jparise jparise mentioned this pull request May 2, 2020
Merged
@jparise jparise requested a review from garrettmoon May 2, 2020 23:50
garrettmoon
garrettmoon reviewed May 20, 2020
View reviewed changes
Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the addition! This is minor, but currently we have a test target for each of the platforms (iOS, macOS and tvOS). Would you mind adding a test target for watchOS as well and we'll get this merged?

@dreampiggy
Copy link
Contributor Author

dreampiggy commented May 21, 2020 •
edited
Loading

Would you mind adding a test target for watchOS as well and we'll get this merged?

@garrettmoon Xcode does not support both Unit Test or UI Test for watchOS.

If Xcode support watchOS test, I can add them...Seems you didn't catch this limit.😂

@garrettmoon
Copy link
Collaborator

I sure didn't! Thanks for the addition, merging now.

garrettmoon
garrettmoon approved these changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

@garrettmoon garrettmoon merged commit 944c1ac into pinterest:master May 21, 2020
@dreampiggy dreampiggy deleted the carthage branch May 22, 2020 02:27
@dreampiggy
Copy link
Contributor Author

Any release date for Carthage support ? So that I can update the PR for PINCache in pinterest/PINCache#269

@dreampiggy
Copy link
Contributor Author

Seems PINOperation does not release new version. PINCache's WatchOS target still broken. @garrettmoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreampiggy @garrettmoon