Close connection if candidates already exist #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boks1971
approved these changes
Nov 21, 2022
Close connection if candidates already exits
Codecov ReportBase: 77.95% // Head: 78.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 77.95% 78.20% +0.25%
==========================================
Files 36 36
Lines 4251 4254 +3
==========================================
+ Hits 3314 3327 +13
+ Misses 729 721 -8
+ Partials 208 206 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aler9
added a commit
to aler9/ice
that referenced
this pull request
Apr 12, 2023
PR pion#496 added a mechanism to close connections of duplicate candidates and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used together, candidates may share the same connection, and candidates may be equal, since their IP is overridden by the one specified in NAT1To1IPs. When a duplicate candidate is found, its connection is closed, making impossible to use any other candidate that shares the same connection. This PR fixes the issue as it prevents duplicate candidates from creating connections and getting their connection closed.
aler9
added a commit
to aler9/ice
that referenced
this pull request
Apr 12, 2023
PR pion#496 added a mechanism to close connections of duplicate candidates and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used together, candidates may share the same connection, and candidates may be equal, since their IPs are overridden by the one specified in NAT1To1IPs. When a duplicate candidate is found, its connection is closed, making impossible to use any other candidate that shares the same connection. This PR fixes the issue as it prevents duplicate candidates from creating connections and getting their connection closed.
aler9
added a commit
to aler9/ice
that referenced
this pull request
Apr 12, 2023
PR pion#496 added a mechanism to close connections of duplicate candidates and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used together, candidates may share the same connection, and candidates may be equal, since their IPs are overridden by the one specified in NAT1To1IPs. When a duplicate candidate is found, its connection is closed, making impossible to use any other candidate that shares the same connection. This PR fixes the issue as it prevents duplicate candidates from creating connections and getting their connection closed.
aler9
added a commit
to aler9/ice
that referenced
this pull request
Apr 12, 2023
PR pion#496 added a mechanism to close connections of duplicate candidates and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used together, candidates may share the same connection, and candidates may be equal, since their IPs are overridden by the one specified in NAT1To1IPs. When a duplicate candidate is found, its connection is closed, making impossible to use any other candidate that shares the same connection. This PR fixes the issue as it prevents duplicate candidates from creating connections and getting their connection closed.
aler9
added a commit
to aler9/ice
that referenced
this pull request
Apr 12, 2023
PR pion#496 added a mechanism to close connections of duplicate candidates and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used together, candidates may share the same connection, and candidates may be equal, since their IPs are overridden by the one specified in NAT1To1IPs. When a duplicate candidate is found, its connection is closed, making impossible to use any other candidate that shares the same connection. This PR fixes the issue as it prevents duplicate candidates from creating connections and getting their connection closed.
aler9
added a commit
to aler9/ice
that referenced
this pull request
Apr 12, 2023
PR pion#496 added a mechanism to close connections of duplicate candidates and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used together, candidates may share the same connection, and candidates may be equal, since their IPs are overridden by the one specified in NAT1To1IPs. When a duplicate candidate is found, its connection is closed, making impossible to use any other candidate that shares the same connection. This PR fixes the issue as it prevents duplicate candidates from creating connections and getting their connection closed.
aler9
added a commit
to aler9/ice
that referenced
this pull request
Apr 12, 2023
PR pion#496 added a mechanism to close connections of duplicate candidates and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used together, candidates may share the same connection, and candidates may be equal, since their IPs are overridden by the one specified in NAT1To1IPs. When a duplicate candidate is found, its connection is closed, making impossible to use any other candidate that shares the same connection. This PR fixes the issue as it prevents duplicate candidates from creating connections and getting their connection closed.
aler9
added a commit
to aler9/ice
that referenced
this pull request
Apr 12, 2023
PR pion#496 added a mechanism to close connections of duplicate candidates and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used together, candidates may share the same connection, and candidates may be equal, since their IPs are overridden by the one specified in NAT1To1IPs. When a duplicate candidate is found, its connection is closed, making impossible to use any other candidate that shares the same connection. This PR fixes the issue as it prevents duplicate candidates from creating connections and getting their connection closed.
aler9
added a commit
to aler9/ice
that referenced
this pull request
Apr 14, 2023
PR pion#496 added a mechanism to close connections of duplicate candidates and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used together, candidates may share the same connection, and candidates may be equal, since their IPs are overridden by the one specified in NAT1To1IPs. When a duplicate candidate is found, its connection is closed, making impossible to use any other candidate that shares the same connection. This PR fixes the issue as it prevents duplicate candidates from creating connections and getting their connection closed.
stv0g
pushed a commit
that referenced
this pull request
Apr 14, 2023
PR #496 added a mechanism to close connections of duplicate candidates and avoid memory leaks. When UDPMuxDefault and NAT1To1IPs are used together, candidates may share the same connection, and candidates may be equal, since their IPs are overridden by the one specified in NAT1To1IPs. When a duplicate candidate is found, its connection is closed, making impossible to use any other candidate that shares the same connection. This PR fixes the issue as it prevents duplicate candidates from creating connections and getting their connection closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When duplicate candidates have been added (both NATMapping and UDPMux enabled), the candidate connection should be closed with the ignored candidate, otherwise, resource is leaked.
Reference issue
Fixes #...