Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GracefulClose #712

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Add GracefulClose #712

merged 2 commits into from
Jul 25, 2024

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Jul 23, 2024

This is part of the epic to get a PeerConnection to have a GracefulClose.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.36%. Comparing base (f15ba98) to head (a5212b0).

Files Patch % Lines
agent_handlers.go 79.31% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
+ Coverage   79.21%   79.36%   +0.15%     
==========================================
  Files          41       41              
  Lines        3743     3780      +37     
==========================================
+ Hits         2965     3000      +35     
- Misses        547      551       +4     
+ Partials      231      229       -2     
Flag Coverage Δ
go 79.36% <85.36%> (+0.15%) ⬆️
wasm 22.47% <29.26%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels merged commit a0385ee into master Jul 25, 2024
13 checks passed
@edaniels edaniels deleted the graceful_close branch July 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants