Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libopus static library to correct arch for darwin arm64 #428

Merged
merged 2 commits into from
Aug 7, 2022

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Aug 6, 2022

@edaniels edaniels requested a review from at-wat August 6, 2022 17:29
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #428 (72b8f50) into master (3bcbed0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   47.32%   47.32%           
=======================================
  Files          67       67           
  Lines        4463     4463           
=======================================
  Hits         2112     2112           
  Misses       2226     2226           
  Partials      125      125           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Sean-Der
Copy link
Member

Sean-Der commented Aug 6, 2022

@edaniels This is just removing, did you also intend to add the correct one?

thanks for opening this PR!

@edaniels
Copy link
Member Author

edaniels commented Aug 6, 2022

@Sean-Der It's a modification! Curious that it's not an add and remove since it's binary.

@at-wat
Copy link
Member

at-wat commented Aug 7, 2022

@edaniels Could you update
https:/pion/mediadevices/blob/master/dockerfiles/darwin-arm64.cmake
https:/pion/mediadevices/blob/master/dockerfiles/darwin-arm64.Dockerfile
to make it cross-compilable?
All other static libraries are built by the scripts in https:/pion/mediadevices/tree/master/dockerfiles and it's very hard to be maintained in the future without cross-compilation.

@edaniels
Copy link
Member Author

edaniels commented Aug 7, 2022

I did this via the make target so there's no changes to make. It looks like the wrong file was originally committed :)

@at-wat
Copy link
Member

at-wat commented Aug 7, 2022

Is pkg/codec/openh264/lib/libopenh264-darwin-arm64.a incorrect as well?

@edaniels
Copy link
Member Author

edaniels commented Aug 7, 2022

lookin good 8)

Non-fat file: ./pkg/codec/openh264/lib/libopenh264-darwin-arm64.a is architecture: arm64
Non-fat file: ./pkg/codec/openh264/lib/libopenh264-darwin-x64.a is architecture: x86_64

Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@at-wat at-wat mentioned this pull request Aug 7, 2022
@edaniels edaniels merged commit 5215057 into pion:master Aug 7, 2022
@edaniels edaniels deleted the opus-darwin-arm64-fix branch August 7, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants