-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose device list update func #463
Conversation
b8a36ca
to
ca0e40a
Compare
Do you think we can expose setup function in other drivers as well? |
Codecov ReportBase: 58.16% // Head: 58.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #463 +/- ##
==========================================
+ Coverage 58.16% 58.21% +0.04%
==========================================
Files 62 62
Lines 3679 3683 +4
==========================================
+ Hits 2140 2144 +4
Misses 1412 1412
Partials 127 127
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@at-wat Done! I skipped the |
@bazile-clyde thanks! I think it would be better in future to have another API that |
That makes sense. I don't have strong opinions either way so I added it. Thanks for the quick turn-around btw! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert import block orders to keep them like
import (
"stdlib1"
"stdlib2"
"nonstdlib1"
"nonstdlib2"
)
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR exports the logic executed at startup to find and register cameras. This will allow us to discover cameras connected after our application has started.