Add YUYV to supported video formats #507
Conversation
|
@bazile-clyde Would you be able to review this for me? I can't add you as a reviewer directly |
@RyanBoring yep! Looking now. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 59.02% 59.02%
=======================================
Files 63 63
Lines 3854 3854
=======================================
Hits 2275 2275
Misses 1446 1446
Partials 133 133
☔ View full report in Codecov by Sentry. |
pkg/frame/decode.go
Outdated
| @@ -17,6 +17,8 @@ const ( | |||
| FormatNV12 = "NV12" | |||
| // FormatYUY2 https://www.fourcc.org/pixel-format/yuv-yuy2/ | |||
| FormatYUY2 = "YUY2" | |||
| // FormatYUYV https://www.fourcc.org/pixel-format/yuv-yuy2/ | |||
There was a problem hiding this comment.
This link isn't working for me. I think it's gone stale. Maybe figure our if fourcc.org has moved to another domain, and if so where. Or you could paste another authoritative link about the YUYV format.
There was a problem hiding this comment.
Wow yeah great catch, I just changed them in a new commit
Description
Add YUYV to supported video formats; used to be implicitly supported under YUY2. That meant the user had to know to ask for YUY2 decoding when using a YUYV device; this PR allows the user to specify YUYV instead.