Use multi-stage docker build for examples/turn-server/simple to reduce container image size #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stv0g
approved these changes
Nov 17, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
==========================================
+ Coverage 67.31% 67.52% +0.21%
==========================================
Files 42 42
Lines 2848 2848
==========================================
+ Hits 1917 1923 +6
+ Misses 769 764 -5
+ Partials 162 161 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
levaitamas
force-pushed
the
multistage-docker-build
branch
from
3f83860
to
db42b73
Compare
levaitamas
force-pushed
the
multistage-docker-build
branch
from
db42b73
to
1c8f150
Compare
|
Thanks @stv0g! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current docker build of examples/turn-server/simple results a large (944MB) image.
This PR implements multi-stage build that reduces image size to 10.2MB.