Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of cabins is incorrectly reported #4806

Closed
pcercuei opened this issue Feb 23, 2020 · 3 comments · Fixed by #4808
Closed

Number of cabins is incorrectly reported #4806

pcercuei opened this issue Feb 23, 2020 · 3 comments · Fixed by #4808

Comments

@pcercuei
Copy link
Contributor

Observed behaviour

With 3 cabins equipped, one used and two available, the game reports in the <F4> menu:
Cabins: 33% 1t used, 3t free

Expected behaviour

The game should report:
Cabins: 33% 1t used, 2t free

My pioneer version (and OS):
git master (e255171), Debian x64

@impaktor
Copy link
Member

Seems like the cabin always shows the total capacity as the current free capacity:
I've filled all my 3 cabins, and the pigui StationView:shipSummary() shows "3t used/3t free".

The NewUI isn't much better, it shows "2 used, 0 free" (should be "3 used, 0 free"). That's a minor point, as we're killing that off today, with #4775.

@impaktor
Copy link
Member

Looks like it's just counting the number of cabins in the "cabin" slot, however, both the occupied and empty cabin are in that slot, thus this error.

@pcercuei
Copy link
Contributor Author

Still not working right. Now I get Cabins: 50% 1 used, 2 free. It should be 33%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants