Buying and selling ship equipment does not require confirmation

[The-EG]

This has popped up in IRC a few times, but I don't think we have an issue to track it, and prod one of us into fixing it.

Observed behaviour

Buying or selling ship equipment does not require a confirmation and can be done with a single click. This isn't intuitive, and usually results in the player inadvertently buying/selling equipment.

Expected behaviour

Buying or selling ship equipment should require a confirmation or function similarly to the commodities screen.

Steps to reproduce

Open the ship equipment screen in a station. Click on a piece of equipment from either the left or right screens.

My pioneer version (and OS):
Current master
Windows 10

[tropicalpioneer]

If I might add, as feature request...a dialog window in some cases #5183

[mwerle]

+1 on this.

The current interface is extremely unintuitive.

In fact, I think that it should not be possible to "Replace" equipment at all. It should only be possible to buy new equipment into an empty slot (with confirmation), forcing the player to first sell any equipment (with confirmation) if the target slot is currently not empty.

More clicking, yes, but far more intuitive, and it's not like equipment changes happen all the time in the game that this needs to be optimised to the fewest clicks possible.

[bszlrd]

Funny you mentioned this. The new equipmemt system of #5734 will address this soon.