Launch request denied - missing crew

[impaktor]

Observed behavior

Starting ship is denied take off, due to missing crew - but there' is enough crew according to ship personnel list. Noteworthy: the crew salary is $0. This is a bit of a bummer, since it will hit new players within minutes of trying the game, unless using the "hard" (illegal) take off button.

Steps to reproduce

• start new game from mars
• F4 for lobby
• click "request launch" --> will be denied (maybe not always? happened 3/3 times for me now)

Steps to NOT get the bug:

• start new game from mars
• F3, then check Crew Roster
• F4 for lobby
• click "request launch" --> works

Should we even have a starting ship that requires crew? If crew has a salary, you have running cost, that a new player might not know how to generate profit fast enough to offset.

My pioneer version (and OS): latest master, e765fd8

[impaktor]

Points of confusion:

• shouldn't there be a call to Ship:GenerateCrew() or Character:Enroll() in pigui/views/mainmenu.lua?
• where does the crew that's there come from? Why salary 0? Is this meant to be the player? If so, it has the wrong name and title.
• all ships have minimum crew = 1, according to shipdef?