Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projectiles/laser appear offset from the ship depending on speed #5695

Closed
bszlrd opened this issue Dec 26, 2023 · 2 comments · Fixed by #5767
Closed

Projectiles/laser appear offset from the ship depending on speed #5695

bszlrd opened this issue Dec 26, 2023 · 2 comments · Fixed by #5767

Comments

@bszlrd
Copy link
Contributor

bszlrd commented Dec 26, 2023

Observed behaviour

On master shots fired appear offset from the ship. It seems to depend on the speed/vector. The faster you fly the further they appear from the ship, like if they are lagging. Or released where you were a split second before.
screenshot-20231226-184726
screenshot-20231226-185301
screenshot-20231226-185312

At zero speed, it come from the right place:
screenshot-20231226-185349

Not sure if FPS affects it, but time acceleration does:
screenshot-20231226-190118

Edit:
Happens to enemy ships too:
screenshot-20231226-191300
And everything snaps back to its proper place when the game is paused:
screenshot-20231226-191304

Expected behaviour

Shots appear at their proper place

Steps to reproduce

Fly fast and shoot your weapons.

My pioneer version (and OS):
20231222 (70d77a2) (I believe it was a translation update build)
Win10

My output.txt (required) and game save (optional, but recommended)

@bszlrd bszlrd changed the title Projectiles appear offset from the ship depending on speed Projectiles/laser appear offset from the ship depending on speed Dec 26, 2023
@JonBooth78
Copy link
Contributor

I think I'm experiencing this too; however, it's not just graphical, I can't seem to be able to engage in dogfights as the lazers are actually shooting way off target best I can tell.

combat-cant-hit.zip

@JonBooth78
Copy link
Contributor

OK, this is caused by 9f10aa2 where we defer adding the bodies (lazer beams/pulses) until the end of the frame/a frame later.

After reverting that change I still can't seem to hit my combat target, however, I can see all the projectiles and they can hit me 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants