Hyperfuel ussage can be avoided.

[ShoweryCellar34]

Observed behaviour

Hyperfuel not used.

Expected behaviour

Hyperfuel is used.

Steps to reproduce

1. Start a hyperjump.
2. Before the countdown finishes put hyperfuel into propellant tank.
3. Wait for hyperjump to complete and see that the fuel put into the propellant tank is still there (the fuel meant to be used for the jump)

My pioneer version (and OS):
Version: 2024/07/10
OS: Windows 11 23H2

My output.txt (required) and game save (optional, but recommended)
output.txt
_exit.zip

[Bodasey]

confirmed

[mwerle]

This was introduced in #2747 on purpose.

It was pending other work (#1719) before further work would be done on this, but it appears that further work has been done. There is now Yet Another New Equipment PR in progress (#5734) which may impact this.

A way to fix this is might be to leave the unconditional jump as-is, but add a Lua callback which is called when the countdown hits 0. Then it is up to the Lua to perform any final checks and return a "go"/"no-go" back to the C++ side.

Alternatively the current "checks" callback firstly needs to actually be provided (it currently isn't), and would need to be called not only during the countdown, but also when the countdown hits 0.

Alternatively-alternatively, instead of hyperspace fuel being kept in the cargo hold and "magically" transferred to the hyperdrive engine on jump, require that the hyperdrive is fuelled up similar to the thrusters in an internal tank. The size of the hyperdrive tank on the engine would be the factor that limits its maximum jump range (for a given mass). This would also allow a jump to use fractional tonnes of fuel which could be part of the hyperspace engine rework idea. Although if fuel can be pumped back into the hold from the engines, then the previous checks would still need to be provided, or the pumps would need to be disabled while the hyperspace engine is spooling up.

[impaktor]

Current plan as mock-up, on how to transfer (fractional)fuel between tanks

[Web-eWorks]

Alternatively-alternatively, instead of hyperspace fuel being kept in the cargo hold and "magically" transferred to the hyperdrive engine on jump, require that the hyperdrive is fuelled up similar to the thrusters in an internal tank.

This is--

part of the hyperspace engine rework idea.

Ah, you've already linked the document.

This is 100% currently planned (and will be implemented in the Stage 2 equipment overhaul) - apparently I wasn't clear enough when writing the hyperdrive redesign proposal that it's intended to migrate fuel use for hyperjumps to an implicit tank in the hyperdrive equipment item similarly to the primary fuel tank.

[mwerle]

apparently I wasn't clear enough when writing the hyperdrive redesign proposal that it's intended to migrate fuel use for hyperjumps to an implicit tank in the hyperdrive equipment item similarly to the primary fuel tank.

I skimmed the proposal a few days back, so I was aware of the proposal in general, but I didn't read (or retain) it in detail.. you did actually mention it:

"When paired with adjusting the maximum size of the hyperspace drive's internal fuel tank, quite a bit of variation can be achived [sic]."

---

Anyway; TL;DR : this is an issue which should be fixed as part of currently-planned work.