Fix GasGiant clipping and bright spots on models #5157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluffyfreak
approved these changes
Mar 27, 2021
| @@ -88,6 +88,8 @@ void main(void) | |||
| #else | |||
| vec3 vNormal = normal; | |||
| #endif | |||
| vNormal = normalize(vNormal); | |||
There was a problem hiding this comment.
Damn, all this time and we just weren't normalizing the normals 🤦♂️ ugh, I must have seent that hundreds of times!
There was a problem hiding this comment.
Yeah, I noticed when I was turning off the lights to test spherical gaussian indirect (and yes, they're in the other branch for you to play with 😄) that most of the light acne disappeared; for the longest time I thought it was just floating point inaccuracy with vertex interpolation, but it turned out to just be out-of-range normals. 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised, this was pulled out of #5156 to be applied to master. This PR contains a fix for planets and gas giants clipping out of the view, and also a fix for the unreported issue of persistent bright-spot acne on our models, most noticeable on the fuselage of the Pumpkinseed (but prevalent pretty much everywhere).
Closes #5145.
These screenshots are identical loads of the same save (including camera position/zoom), showing the difference with this change applied.
Before:
After: