Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fuel scooping less of a suicide #5281

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

joonicks
Copy link
Contributor

@joonicks joonicks commented Sep 25, 2021

speed and density factored in to how much is scooped hasnt changed, only the threshold where it starts scooping

scooping is still non-trivial

Fixes #5237

speed and density factored in to how much is scooped hasnt changed, only the threshold where it starts scooping

scooping is still non-trivial
@bszlrd
Copy link
Contributor

bszlrd commented Sep 25, 2021

Feels good to me, based on the save I got from discord. I was able to scoop a full hold of H2 with a Mola Mola, and still had to climb out to orbit.

@bszlrd
Copy link
Contributor

bszlrd commented Sep 25, 2021

I've took the liberty to edit your description with the Fixes #5237 line for auto-closing that issue upon merge

@joonicks
Copy link
Contributor Author

note to reviewers: the ease of fuel scooping depends heavily on the planet youre scooping.

without the patch I had to nose-down pretty hard and pass below 40km altitude, praying that aerodynamics wouldnt push me into a death spin and that id'd be able to pull up again, while having maybe a 50/50 chance of scooping anything.

this patch changes scooping from a russian roulette to "keep your hands on the wheel at all times"

@Web-eWorks Web-eWorks merged commit 4bf865e into pioneerspacesim:master Oct 1, 2021
@joonicks joonicks deleted the fuel-scooping branch October 6, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuel Scoop not functioning
3 participants