-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check spaceport being behind a body while drawing nav target indicator #5438
Conversation
Check whether nav target is a ground station below the horizon and draw nav target indicator accordingly.
Do we want this for ships as well? Is it needed / possible? |
Also, this is only a draft because I didn't figure out what to do with the indicator after performing the check. |
Nice! |
Dashes sound good. I agree that the crossed out implies more like something that's forbidden. |
I've thought about switching to a circular target outline rather than square when the target is on the reverse side of the planet. A dashed outline is fine-ish, but it's already a very small outline and making it dashed may not be readily apparent. |
Circle and diamond are also good. Given the choice I would go with circle to increase the contrast. |
I quite like your negative-space square, @WKFO. Have you exhausted/rejected the idea of the standard indicator in a different colour? I had no problem with the red indicator in your video... unless a red indicator is used for other scenarios (combat target?) Would a blue square work? Would want the colour scheme to be consistent - not sure if there is a style guide around this. |
Shape is always clearer than color for reading at a glance. Especially if we take the 10% colorblind in the population into account. |
Thanks @nozmajner - all good reasons and nicely explained. I think I've exhausted my input 😄 Happy with whatever is decided. |
Generally speaking there is enough information already presented by "overloading" the same UI elements with different meanings in different colors that I don't want to add yet another distinct color tone into the mix. Not only is symbology a better fit for this, but this keeps our options open for the future to allow e.g. manufacturer-specific HUDs or users to better configure the color and theme of the UI. The standard indicator is also already colored to indicate whether it is a nav- or combat target, so color is not a great fit here.
IIRC a circle is currently only used for the frame-up-direction indicator, which by nature will never be coincident with a target on the other side of the planet. It's also rendered in a different color to both the nav and combat targets, which makes it a viable candidate in addition to the natural symbology of a planetary circle for a target on the other side of a planet...
Personally I'd rather the diamond currently used for the prograde vector be replaced with a more standard prograde indicator of some sort, as diamonds are a very general-purpose shape and could be used for a number of different symbology options, including a target with no clear line of sight. This is not to say the diamond is a bad prograde indicator, merely that it could have many more uses. |
Also adds dashed nav target icon by nozmajner. Co-Authored-By: Szlrd <[email protected]>
Now also checks for orbital stations being behind the body. Also the icon is added. The PR should be ready to test & review. |
I stumbled over this error: Warning: Caught error in Lua UI code: The crosshair and the square disappear sometimes. |
Dashed lines are customary for invisible lines in any technical drawing so it would be quite intuitive. |
...when there is no framebody.
Yeah, right, sometimes one simply doesn't have a frameBody. Should be fixed now, with the latest commit. |
Just a note to say thank you for this work, @WKFO - I am finding it really useful. And the dashed square works well. Would you consider extending this to (at least landed) ships also? On the rescue mission pictured below, it would have been great to know at a glance that the ship in distress was on the far side of the horizon. |
The math works exactly the same for any target so this feature can be extended for pretty much all targets. This seems like a useful case so why not? That being said I need to find time to get to do that. |
PR #5481 contains what you request. I found it very useful too and extended it for all types of targets. |
Draw nav target icon differently for starports that are behind the frame body.
Demo: https://www.youtube.com/watch?v=7KSaPZqU9eA
The math may not hold too well with ground ports on concave-shaped asteroids but it still would be better than not having it at all IMHO.