Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken screenshots links #5761

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

VasanthBalguri
Copy link
Contributor

Fixed broken screenshots links in metainfo.xml file
Fixes #5747 issue

Fixed broken screenshots links in metainfo.xml file
Copy link
Member

@Web-eWorks Web-eWorks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These images should not be sourced from a link to the file in the source tree, as they're unlikely to embed properly at all (Github serves an HTML document at that link rather than a PNG file).

These images are available as https://pioneerspacesim.net/carousel/ss1.png etc. and should be linked to using links of that form instead.

@impaktor
Copy link
Member

Sorry, might have been me that sent @VasanthBalguri down the wrong track.

updated as per comments
@VasanthBalguri
Copy link
Contributor Author

Hi, I made changes according to comments.
I observed that release is still pointing to old one, is it intentional?

<releases>
<release version="20190203" date="2019-02-03" />
<release version="20180203" date="2018-02-03" />
</releases>

@Web-eWorks
Copy link
Member

That's not intentional, the metainfo file just hasn't been updated since then.

@VasanthBalguri
Copy link
Contributor Author

VasanthBalguri commented Feb 13, 2024 via email

@impaktor
Copy link
Member

Oh okay, then I will update, is it okay?

Yes please

@VasanthBalguri
Copy link
Contributor Author

It is done @impaktor and @Web-eWorks, pleas check.

@Web-eWorks Web-eWorks merged commit c8341e7 into pioneerspacesim:master Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links in net.pioneerspacesim.Pioneer.metainfo.xml
3 participants