Generate atmospheres for gas giants in legacy custom systems #5766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Gas giants previously depended on a fixed 14.0 atmospheric density - Add an import step which generates a plausible atmospheric density if a gas giant defined in Lua doesn't have its atmosphere set.
|
Here is a save file for testing |
|
Just gave this a quick test and it appears to work. I haven't tried testing but the assert no longer appears when loading the above save, which means the density is > 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the merge of the System Editor and associated system generation refactor, all gas giants had a fixed 14.0 kg/m3 atmospheric surface density value which overrode the value of
m_volatileGasand thus many Lua custom systems never set the atmospheric density parameter, which resulted gas giants in custom systems (e.g. Sol, Noril, etc.) missing scoopable atmospheres.Sol was resolved by manually editing the gas giants to set density to real-world values; this PR follows up and adds an additional "fixup" step when loading legacy Lua custom systems that generates "missing" atmospheric density values for gas giants.
Testing Steps:
Visit Noril C and attempt to scoop it for fuel. It should have an atmospheric density > 0 before you crash 😉