Fix incorrect position of starports #5793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Existing spaceports were defined in Lua with negative inclination/longitude, but constrained to only positive on load
- std::strtol returns a 32-bit signed integer on Windows but 64-bit on Linux - Use 64-bit version to ensure we can load the entire fractional bit range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a platform-specific issue where on Windows a fixed-point fractional part greater than 0.5 was being silently truncated when loaded from JSON files. This is most likely the cause for starport positions to be completely incorrect on Windows specifically.
This PR also addresses the log warnings about negative inclination values coming from legacy Lua-based systems until such a time as we convert all such systems to JSON.
Fixes #5792, fixes #5744.