-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phpunit version check error returns two failed tests #11
Comments
…_03-github-actions-i11##
…_03-github-actions-i11##
…_03-github-actions-i11##
Hi @asmecher , I have in OJS 3.3 github actions the issue, that the above tests fai for php 8.0+, cause it assumes that the php version shoud be larger, https:/pkp/pkp-lib/pull/9788/files But this seems to me like, it is related to the phpunit 10 support, which drops expectError() However after my change of assuming a larger phpunit version, travis tests for ojs 3.3. , 8.0+ fails, what I think is a valiadtion error. I tested my change with GA https:/withanage/ojs/actions/runs/8189570913 I am a little unsure there, could you take a look ? |
I might be missing the point -- I haven't gone into this deeply -- but wouldn't it make sense to check both the PHP version and phpunit version? Obviously if PHPUnit doesn't have |
Yes, it colud be the proecess of Thanks Alec, restricting both would be better and stop travis tests from braking too. |
…_03-github-actions-i11##
…_03-github-actions-i11##
Bug
phpunit version creates 2 errors:
It seems that the PHPUnit version check doesn't match the PHP version. In OJS 3.3, we're using PHPUnit 9.5, which is causing the tests to fail. A more consistent approach would be to verify the PHPUnit version.
Vendor Information
sebastianbergmann/phpunit#5062
The text was updated successfully, but these errors were encountered: