Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce burden on users and maintainers via upgrade scripts #10

Open
epage opened this issue Oct 18, 2021 · 3 comments
Open

Reduce burden on users and maintainers via upgrade scripts #10

epage opened this issue Oct 18, 2021 · 3 comments

Comments

@epage
Copy link

epage commented Oct 18, 2021

Requiring users to pull and build large dependencies for one-off upgrades is a barrier to adoption.

What if cargo-up support rhai or lua upgrade scripts? We only need to compile or install a pre-built binary of `cargo-up. Crates could include the scripts in pre-determined locations in crates so they can be automatically be detected and ran.

@pksunkara
Copy link
Owner

The main reason for keeping this in rust is so that the migrators can use the underlying capability provided by Semantics provided by rust_analyzer which can do a lot of cool stuff.

I am not sure about rhai and if we can do the same here.

And I guess for some easy migrators that don't need all that complex stuff, we can provide an alternative way to define the script.

Requiring users to pull and build large dependencies for one-off upgrades is a barrier to adoption.

Definitely agree. Which is why we build the tool in cargo-up-cache. So it's only built for a long time during the first invocation on your system.

@epage
Copy link
Author

epage commented Oct 19, 2021

Yeah, I fully agree that doing my suggestion would require writing a lot of bindings, the more featureful the scripts supported, the more bindings required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@epage @pksunkara and others