You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @RichardHeltec, these boards were added in Arduino core v3.x which is not supported at the moment. Besides, your manifest files needs some adjustments, please review my comments above.
Hi @RichardHeltec, these boards were added in Arduino core v3.x which is not supported at the moment. Besides, your manifest files needs some adjustments, please review my comments above.
Sorry, my mistake. I have made the modification. Please review it again.
@RichardHeltec I believe the board-specific macro should be uppercase, e.g. -DARDUINO_HELTEC_WIRELESS_PAPER
Hi, Valerii. If capitalization is necessary, I will make the necessary modifications. At the same time, I found that the boards that are already running on the platform, such as "wifi lora 32 v3", "wifi kit v3", are still lowercase, should I change them?
At the same time, I found that the boards that are already running on the platform, such as "wifi lora 32 v3", "wifi kit v3", are still lowercase, should I change them?
It seems like an old typo from a PR. Anyway, it would be great, but please submit your fixes in a separate pull request.
Hi, Valerii. This morning, I was feeling dazed. I thought I saw my commit being merged, so I updated my branch again. It turns out I was wrong now. I'm not sure if it will affect your review.
These boards are already integrated into Espressif's framework.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Heltec Wireless Paper and Wireless Tracker.
Wireless Tracker
Wireless Paper