New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): misc fixes #8

Merged

Zyie merged 4 commits into main from chore.misc-fixes

Apr 22, 2024

GoodBoyDigital commented Apr 19, 2024

fixed json and test
fixed texture packer still creating individual images
ensure output is removed if the cache key changes
add skip property and skipChildren


- add skip property and skipChildren

8aca520

- fixed json and test
- fixed texture packer still creating individual images
- ensure output is removed if the cache key changes

This comment was marked as outdated.

Sign in to view


-test tweak

ce1e477

- fix compressed pngs not working

This comment was marked as outdated.

Sign in to view


fix rotation on texture packer

267bcf2

This comment was marked as outdated.

Sign in to view

Zyie changed the title ~~Misc fixes~~ Fix(core): misc fixes

This comment was marked as outdated.

Sign in to view

Zyie reviewed

View reviewed changes

packages/core/src/AssetPack.ts Show resolved Hide resolved

Zyie reviewed

View reviewed changes

packages/json/test/Json.test.ts Outdated Show resolved Hide resolved


pr feedback

a49f687

This comment was marked as outdated.

Sign in to view

GoodBoyDigital requested a review from Zyie

April 22, 2024 09:00

Zyie changed the title ~~Fix(core): misc fixes~~ Fix(plugin-core): misc fixes

This comment was marked as outdated.

Sign in to view

Zyie changed the title ~~Fix(plugin-core): misc fixes~~ Fix(core): misc fixes

This comment was marked as outdated.

Sign in to view

Zyie changed the title ~~Fix(core): misc fixes~~ fix(core): misc fixes

Zyie approved these changes

View reviewed changes

Zyie merged commit 973ef7d into main

2 of 6 checks passed

Zyie deleted the chore.misc-fixes branch

April 22, 2024 09:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment