Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect statement in "Doing More With Docker Images" #142

Open
rcjsuen opened this issue May 27, 2018 · 0 comments
Open

Incorrect statement in "Doing More With Docker Images" #142

rcjsuen opened this issue May 27, 2018 · 0 comments

Comments

@rcjsuen
Copy link

rcjsuen commented May 27, 2018

In Doing More With Docker Images, it says the following...


What just happened?
We created two files: our application code (index.js) is a simple bit of javascript code that prints out a message. And the Dockerfile is the instructions for Docker engine to create our custom container. This Dockerfile does the following:

  1. Specifies a base image to pull FROM - the alpine image we used in earlier labs.
  2. Then it RUNs two commands (apk update and apk add) inside that container which installs the Node.js server.
  3. Then we told it to COPY files from our working directory in to the container. The only file we have right now is our index.js.
  4. Next we specify the WORKDIR - the directory the container should use when it starts up
  5. And finally, we gave our container a command (CMD) to run when the container starts.

The third bullet point claims that: "The only file we have right now is our index.js."
However, this is not correct because the Dockerfile also exists in ./ so both files are actually copied into the /app folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant