Add rule to suggest using built-in locators (prefer-native-locators)
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskelton
reviewed
Aug 24, 2024
mskelton
reviewed
Aug 24, 2024
mskelton
reviewed
Sep 3, 2024
mskelton
reviewed
Sep 3, 2024
mskelton
reviewed
Sep 3, 2024
mskelton
approved these changes
Sep 3, 2024
|
@mskelton I added some additional test cases based on real-world usage that I was able to find. I am feeling pretty confident in it overall. Feel free to merge if you'd like. |
|
And thank you for reviewing all of the feedback! |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getBy*selectors #203This PR adds a rule for suggesting usage of built-in locators when there is an equivalent to a custom locator that is being used. Rather than trying to rewrite all possible custom locators, I've focused on a cases that are auto-fixable and should have a low false positive rate. So, more complex locators (including text queries) were not included in this initial PR. We should expand this rule to accommodate for other cases in the future.