Fix Bug? in FindCellsToCheck causing return of NAs in unassigned_cells and causes errors downstream #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_level_round instead of multiple outputs. Otherwise would produce NAs in the unassigned_cells being returns and crash.
Bug for FineCellstoCheck, adding unique() to return just the previous…
Open
|
For this error, may I ask whether you have run any cell filtering? |
|
We did fix some issue with the unassigned cells. Please try the new main branch. |
|
Thank you, I will get it a try soon, and keep you updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding unique() , similar to what is done in with FindCellsWithId
Otherwise causes errors during CalculateScores