Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DeprecationWarning from a moved p.a.z3cform.widgets import #387

Merged
merged 2 commits into from
May 12, 2024

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented May 2, 2024

No description provided.

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens jensens force-pushed the remove-p.a.widgets-deprecation-warning branch from 2869103 to 5694628 Compare May 2, 2024 15:51
@jensens
Copy link
Sponsor Member Author

jensens commented May 2, 2024

@jenkins-plone-org please run jobs

@jensens jensens marked this pull request as ready for review May 2, 2024 15:51
@jensens jensens force-pushed the remove-p.a.widgets-deprecation-warning branch from 5694628 to 1bc6fc4 Compare May 2, 2024 15:57
@jensens
Copy link
Sponsor Member Author

jensens commented May 2, 2024

@jenkins-plone-org please run jobs

2 similar comments
@jensens
Copy link
Sponsor Member Author

jensens commented May 2, 2024

@jenkins-plone-org please run jobs

@jensens
Copy link
Sponsor Member Author

jensens commented May 3, 2024

@jenkins-plone-org please run jobs

@jensens
Copy link
Sponsor Member Author

jensens commented May 7, 2024

@jenkins-plone-org please run jobs

@petschki
Copy link
Member

petschki commented May 7, 2024

CI tests for 6.0 should be dropped as this change targets Plone 6.1 only

@davisagli
Copy link
Sponsor Member

@petschki If there are changes which are for 6.1 only, then a new maintenance branch needs to be created from current master and set as the source in https:/plone/buildout.coredev/blob/6.0/sources.cfg /cc @mauritsvanrees

Then something needs to happen to make mr.roboto notice the change -- is that manual or automatic @gforcada?

@petschki
Copy link
Member

petschki commented May 8, 2024

branches from sources.cfg are picked automatically by mr.roboto ... @jensens could you create a maintenance branch here?

@jensens jensens force-pushed the remove-p.a.widgets-deprecation-warning branch 4 times, most recently from 819e4c6 to 3593e89 Compare May 10, 2024 14:13
@jensens jensens force-pushed the remove-p.a.widgets-deprecation-warning branch from 3593e89 to 956fe9d Compare May 10, 2024 14:19
@jensens
Copy link
Sponsor Member Author

jensens commented May 10, 2024

@jenkins-plone-org please run jobs

@gforcada
Copy link
Sponsor Member

@davisagli (and everyone anyway), mr.roboto indeed updates the branches automatically.

You can see the matrix of plone version / package / branch used in the following page:

https://jenkins.plone.org/roboto/branches

Note: red means that the package is checked out in checkouts.cfg

@jensens jensens changed the title Remove DeprecationWarning from a moved p.a.widgets import Remove DeprecationWarning from a moved p.a.z3cform.widgets import May 12, 2024
@jensens jensens force-pushed the remove-p.a.widgets-deprecation-warning branch from 956fe9d to 7119142 Compare May 12, 2024 17:49
@jensens jensens merged commit e27d598 into master May 12, 2024
9 of 11 checks passed
@jensens jensens deleted the remove-p.a.widgets-deprecation-warning branch May 12, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants