Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Register #4861

Merged
merged 39 commits into from
Aug 13, 2024
Merged

Refactor Register #4861

merged 39 commits into from
Aug 13, 2024
+120 −142

Conversation

Tishasoumya-02
Copy link
Contributor

@Tishasoumya-02 Tishasoumya-02 commented Jun 9, 2023 •
edited
Loading

@netlify
Copy link

netlify bot commented Jun 9, 2023 •
edited
Loading

✅ Deploy Preview for volto ready!

Name Link
🔨 Latest commit 776bac0
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6521724cbd5d4400086a18c6
😎 Deploy Preview https://deploy-preview-4861--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Jun 9, 2023 •
edited
Loading

Passing run #6939 ↗︎

0 553 20 0 Flakiness 0

Details:

Merge branch 'master' into refactor-register
Project: Volto Commit: d3aed85940
Status: Passed Duration: 18:03 💡
Started: Aug 22, 2023 11:00 AM Ended: Aug 22, 2023 11:18 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

nileshgulia1
nileshgulia1 requested changes Jun 19, 2023
View reviewed changes
Copy link
Member

@nileshgulia1 nileshgulia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the comments.

@nileshgulia1 nileshgulia1 mentioned this pull request Jun 19, 2023
Merged
nileshgulia1
nileshgulia1 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@nileshgulia1 nileshgulia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it on the context of refactor. We still have to take care of original fix, maybe in a different PR?

@netlify Netlify
Copy link

netlify bot commented Jul 26, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 66ea6d6
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66b9a78abfc1ca000851d561

@JeffersonBledsoe
Merge branch 'main' into refactor-register
2c5a6d4 
# Conflicts:
#	packages/volto/src/components/theme/Register/Register.jsx
#	packages/volto/src/components/theme/Register/Register.stories.jsx
@JeffersonBledsoe
Copy link
Member

@plone/volto-team Updated to the lastest main. Happy for this to be merged?

@stevepiercy stevepiercy mentioned this pull request Aug 5, 2024
Open
@stevepiercy
Copy link
Collaborator

I restarted failed checks, which I think are flaky.

I also created a new issue from @JeffersonBledsoe's comment in #6233.

This PR is concerned only with refactoring.

@Tishasoumya-02
Copy link
Contributor Author

I'm running into this error when trying to edit or create a page/news etc.
image

@stevepiercy
Copy link
Collaborator

@Tishasoumya-02 I'm not clear what that error has to do with this PR. Can you elaborate?

Also please do not paste images of error messages. Paste the entire text into a comment surrounded by triple backticks to format it.

```
error message
```

@Tishasoumya-02
Copy link
Contributor Author

Sorry for the noise ! I was getting this error every time I was trying to create a new document, after make clean then make install , it started working !

@Tishasoumya-02
Copy link
Contributor Author

@Tishasoumya-02 I'm not clear what that error has to do with this PR. Can you elaborate?

Also please do not paste images of error messages. Paste the entire text into a comment surrounded by triple backticks to format it.

error message

Yes, will keep in mind! Thanks :)

@davisagli davisagli merged commit f651bf6 into main Aug 13, 2024
69 of 70 checks passed
@davisagli davisagli deleted the refactor-register branch August 13, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichim-david ichim-david ichim-david left review comments

@davisagli davisagli davisagli approved these changes

@stevepiercy stevepiercy stevepiercy approved these changes

@nileshgulia1 nileshgulia1 nileshgulia1 approved these changes

@sneridagh sneridagh Awaiting requested review from sneridagh

@JeffersonBledsoe JeffersonBledsoe Awaiting requested review from JeffersonBledsoe

Assignees
No one assigned
Labels
24 status: ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Tishasoumya-02 @JeffersonBledsoe @stevepiercy @davisagli @ichim-david @nileshgulia1