Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Edit.jsx #6185

Closed
wants to merge 2 commits into from
Closed

Refactor Edit.jsx #6185

wants to merge 2 commits into from

Conversation

FreakForever
Copy link

Ref: #4960

About This PR
This PR refactored

/packages/volto/src/components/manage/Blocks/Video/Edit.jsx

from class based to functional component.

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit ed2b0b7
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/669fe1422b396300084d80df

@stevepiercy
Copy link
Collaborator

@FreakForever please read and follow Update your pull request from your fork and Change log entry.

@stevepiercy
Copy link
Collaborator

@FreakForever I just realized, you linked to another PR. Why did you duplicate effort? See https://6.docs.plone.org/contributing/first-time.html#mistake-2-label

@stevepiercy
Copy link
Collaborator

Closing as duplicate of #4960.

@FreakForever FreakForever deleted the video-edit branch July 25, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants