Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels accessibility for ArrayWidget,SelectWidget,TokenWidget #6332

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Labels accessibility for ArrayWidget,SelectWidget,TokenWidget #6332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd2f92d
Squash commits
folix-01 Sep 26, 2024
0016fd4
Update 6332.bugfix
folix-01 Sep 26, 2024
0881397
Update packages/volto/news/6332.bugfix
pnicolli Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/volto/news/6332.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Labels accessibility for ArrayWidget, SelectWidget, TokenWidget. @folix-01
1 change: 1 addition & 0 deletions packages/volto/src/components/manage/Widgets/ArrayWidget.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ class ArrayWidget extends Component {
// small fix for https:/clauderic/react-sortable-hoc/pull/352:
getHelperDimensions={({ node }) => node.getBoundingClientRect()}
id={`field-${this.props.id}`}
aria-labelledby={`fieldset-${this.props.fieldSet}-field-label-${this.props.id}`}
key={this.props.id}
isDisabled={this.props.disabled || this.props.isDisabled}
className="react-select-container"
Expand Down
1 change: 1 addition & 0 deletions packages/volto/src/components/manage/Widgets/SelectWidget.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ class SelectWidget extends Component {
id={`field-${id}`}
key={choices}
name={id}
aria-labelledby={`fieldset-${this.props.fieldSet}-field-label-${id}`}
menuShouldScrollIntoView={false}
isDisabled={disabled}
isSearchable={true}
Expand Down
1 change: 1 addition & 0 deletions packages/volto/src/components/manage/Widgets/TokenWidget.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ class TokenWidget extends Component {
<FormFieldWrapper {...this.props}>
<CreatableSelect
id={`field-${this.props.id}`}
aria-labelledby={`fieldset-${this.props.fieldSet}-field-label-${this.props.id}`}
key={this.props.id}
menuShouldScrollIntoView={false}
isDisabled={this.props.isDisabled}
Expand Down
2 changes: 2 additions & 0 deletions packages/volto/src/components/manage/Widgets/__snapshots__/ArrayWidget.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ exports[`No 'No value' option when default value is 0 1`] = `
>
<input
aria-autocomplete="list"
aria-labelledby="fieldset-default-field-label-my-field"
autocapitalize="none"
autocomplete="off"
autocorrect="off"
Expand Down Expand Up @@ -212,6 +213,7 @@ exports[`renders an array widget component 1`] = `
>
<input
aria-autocomplete="list"
aria-labelledby="fieldset-default-field-label-my-field"
autoCapitalize="none"
autoComplete="off"
autoCorrect="off"
Expand Down
2 changes: 2 additions & 0 deletions packages/volto/src/components/manage/Widgets/__snapshots__/SelectWidget.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ exports[`No 'No value' option when default value is 0 1`] = `
>
<input
aria-autocomplete="list"
aria-labelledby="fieldset-default-field-label-my-field"
autocapitalize="none"
autocomplete="off"
autocorrect="off"
Expand Down Expand Up @@ -222,6 +223,7 @@ exports[`renders a select widget component 1`] = `
>
<input
aria-autocomplete="list"
aria-labelledby="fieldset-default-field-label-my-field"
autocapitalize="none"
autocomplete="off"
autocorrect="off"
Expand Down
1 change: 1 addition & 0 deletions packages/volto/src/components/manage/Widgets/__snapshots__/TokenWidget.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ exports[`renders a token widget component 1`] = `
>
<input
aria-autocomplete="list"
aria-labelledby="fieldset-default-field-label-my-field"
autoCapitalize="none"
autoComplete="off"
autoCorrect="off"
Expand Down
Loading