Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insiderange with category axes #6910

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Fix insiderange with category axes #6910

merged 4 commits into from
Mar 1, 2024

Conversation

alexcjohnson
Copy link
Collaborator

also presumably for log axes

This figure:

var data = [
    {
        "name": "bar",
        "x": [
            "A",
            "B",
            "C",
            "D"
        ],
        "y": [
            50,
            70,
            90,
            35
        ],
        "type": "bar"
    }
];
var layout = {
    "xaxis": {
        "type": "category",
        "insiderange": [1, 2]
    },
    "yaxis": {
      "side": "right",
      "ticklabelposition": "inside top"
    },
    "width": 400
};
Plotly.newPlot(gd, data, layout);

on current master looks like:
Screenshot 2024-02-28 at 21 19 57

but this PR fixes it to look like:
Screenshot 2024-02-28 at 21 20 39

I haven't tested with a log x axis but I expect that was also broken and fixed by this change.

fixes insiderange for category axes, also presumably for log axes
@archmoj archmoj added bug something broken status: reviewable labels Mar 1, 2024
@archmoj
Copy link
Contributor

archmoj commented Mar 1, 2024

💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants