Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate on custom bundle instructions #7101

Merged
merged 25 commits into from
Aug 13, 2024

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Aug 13, 2024

For custom builds, it seems easier to just clone the repo, aligned with the contrib guide, instead of the somewhat atypical approach to npm installing it and go to the node_modules/plotly.js for making custom builds

CUSTOM_BUNDLE.md Outdated Show resolved Hide resolved
Co-authored-by: Mojtaba Samimi <[email protected]>
@archmoj
Copy link
Contributor

archmoj commented Aug 13, 2024

How about adding both install and clone options with some basic information of the advantages of each one?
E.g. installing may be simpler for some users and they get latest official version instead an unstable/unreleased work on master.

@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 13, 2024

@archmoj , good catch! I've updated the instructions to include a version (tags)

CUSTOM_BUNDLE.md Outdated Show resolved Hide resolved
@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 13, 2024

I made a note, to check the CONTRIBUTING.md list of prerequisites for node/npm version after the clone of a specific version, so that it'll be aligned.

@birkskyum birkskyum changed the title update custom bundle instruction to clone update custom bundle instructions Aug 13, 2024
CUSTOM_BUNDLE.md Outdated Show resolved Hide resolved
@birkskyum birkskyum changed the title update custom bundle instructions Elaborate on custom bundle instructions Aug 13, 2024
CUSTOM_BUNDLE.md Outdated Show resolved Hide resolved
CUSTOM_BUNDLE.md Outdated Show resolved Hide resolved
CUSTOM_BUNDLE.md Outdated Show resolved Hide resolved
CUSTOM_BUNDLE.md Outdated Show resolved Hide resolved
birkskyum and others added 2 commits August 13, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants