-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hybrid upwind #1117
Draft
enricoballini
wants to merge
55
commits into
pmgbergen:develop
Choose a base branch
from
enricoballini:hybrid_upwind_clean
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Hybrid upwind #1117
enricoballini
wants to merge
55
commits into
pmgbergen:develop
from
enricoballini:hybrid_upwind_clean
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… boundaries for NO fracture problem. need to compare the code with the previous version.
enricoballini
requested review from
keileg,
IvarStefansson and
OmarDuran
as code owners
January 28, 2024 14:34
Thanks, @enricoballini. As we agreed, @OmarDuran and I will have a look at this in due course, likely doing (substantial) changes, but the burden is off your shoulders. |
keileg
added
the
PR - stale
A PR that is stale, but it will be resumed eventually.
label
Feb 2, 2024
@OmarDuran I formally converted this to draft, since it may take some time before we have the capacity to work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the hybrid upwind discretization scheme following https://doi.org/10.1016/j.cma.2021.114288
Checklist
Put an
x
in the boxes that apply or explain briefly why the box is not relevant.pytest
was run with the--run-skipped
flag.