Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid upwind #1117

Draft
wants to merge 55 commits into
base: develop
Choose a base branch
from

Conversation

enricoballini
Copy link
Contributor

@enricoballini enricoballini commented Jan 28, 2024

This PR adds the hybrid upwind discretization scheme following https://doi.org/10.1016/j.cma.2021.114288

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • [x ] New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

enricoballini and others added 30 commits April 26, 2023 14:16
… boundaries for NO fracture problem. need to compare the code with the previous version.
@keileg
Copy link
Contributor

keileg commented Jan 29, 2024

Thanks, @enricoballini. As we agreed, @OmarDuran and I will have a look at this in due course, likely doing (substantial) changes, but the burden is off your shoulders.

@keileg keileg added the PR - stale A PR that is stale, but it will be resumed eventually. label Feb 2, 2024
@keileg keileg marked this pull request as draft February 2, 2024 12:07
@keileg
Copy link
Contributor

keileg commented Feb 2, 2024

@OmarDuran I formally converted this to draft, since it may take some time before we have the capacity to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR - stale A PR that is stale, but it will be resumed eventually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants