fix a test, add comments

pmndrs · Nov 3, 2021 · 39d8e66 · 39d8e66
1 parent e0c44d1
commit 39d8e66
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/middleware.ts b/src/middleware.ts
@@ -206,7 +206,7 @@ export const devtools =
 
 export type StoreApiWithSubscribeWithSelector<T extends State> = Omit<
  StoreApi<T>,
- 'subscribe'
+ 'subscribe' // FIXME remove omit in v4
 > & {
  subscribe: {
  (listener: StateListener<T>): () => void
@@ -233,7 +233,7 @@ export const subscribeWithSelector =
  (
  set: CustomSetState,
  get: CustomGetState,
- api: Omit<CustomStoreApi, 'subscribe'> &
+ api: Omit<CustomStoreApi, 'subscribe'> & // FIXME remove omit in v4
  StoreApiWithSubscribeWithSelector<S>
  ): S => {
  const origSubscribe = api.subscribe as Subscribe<S>
@@ -255,7 +255,11 @@ export const subscribeWithSelector =
  }
  return origSubscribe(listener)
  }) as any
- const initialState = fn(set, get, api as CustomStoreApi)
+ const initialState = fn(
+ set,
+ get,
+ api as CustomStoreApi // FIXME can remove in v4?
+ )
  return initialState
  }
 

diff --git a/tests/middlewareTypes.test.tsx b/tests/middlewareTypes.test.tsx
@@ -368,8 +368,7 @@ describe('counter state spec (double middleware)', () => {
  persist(
  (set, get) => ({
  count: 1,
- inc: () =>
- set({ count: get().count + 1 }, false /* TODO , 'inc' */),
+ inc: () => set({ count: get().count + 1 }, false, 'inc'),
  }),
  { name: 'count' }
  ),