Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Issue 1571 & Partial fix for 1174 #1575

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Fixing Issue 1571 & Partial fix for 1174 #1575

merged 3 commits into from
Jul 9, 2023

Conversation

NishkalankBezawada
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1571, partially #1174, mentioned in #Z

What's in this Pull Request?

Problem statement

When a column in list of type number, is configured with minimum and maximum value, the validation works fine on the list form but not in the Dynamic form. On dynamic form, user can enter any value and submit as mentioned in the issue 1571

Solution

Fixing the ability to validate the number field when minimum and maximum value is defined in the list.

I have added three field properties minimumValue, maximumValue, showAsPercentage

image

(These properties are only available for Number field)

These properties are added to the fieldCollection and validates in the dynamic form according to the changedValue/newValue accordingly.

Thanks,
Nishkalank Bezawada

@IRRDC
Copy link
Contributor

IRRDC commented Jul 4, 2023

@NishkalankBezawada The text you have added to the German locale file is Dansk.
The German text is "Der Wert dieses Feldes muss zwischen {0} und {1} liegen."
Translations into other languages seem to be missing too.

@NishkalankBezawada
Copy link
Contributor Author

Der Wert dieses Feldes muss zwischen {0} und {1} liegen.

Thanks @IRRDC I will correct those.

@AJIXuMuK AJIXuMuK merged commit 7cd2482 into pnp:dev Jul 9, 2023
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 9, 2023

@NishkalankBezawada - thanks for the changes. I have merged it but left few comments for you as FYI.
I will make these changes but in future please take them into consideration.

@AJIXuMuK AJIXuMuK added this to the 3.15.0 milestone Jul 9, 2023
@NishkalankBezawada
Copy link
Contributor Author

@NishkalankBezawada - thanks for the changes. I have merged it but left few comments for you as FYI.

I will make these changes but in future please take them into consideration.

Thanks Alex, have you added any comments here? I can't able to find those.

@NishkalankBezawada NishkalankBezawada deleted the Issue-1174 branch July 10, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants