Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to 1.20.0 #5277

Merged

Conversation

ValerasNarbutas
Copy link
Contributor

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ), make notes next to any that haven't been addressed.

What's in this Pull Request?

SPFX upgrade to 1.20.0 version

Node Version

Node version used: 18.17.1

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@Adam-it Adam-it self-assigned this Oct 4, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Oct 5, 2024

Thank you for opening a PR to our samples repo and helping us upgrade our project 👍
We will try to review this PR ASAP

Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValerasNarbutas Awesome work 👏👏👏 You Rock 🤩
I managed to build it locally and played with it a bit.
During my review I noticed some small details we could sort out before we merge 👍. Please do give them a double check 🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should not be here. The sample.json should be present in the assets folder in the root of the project and is used to store metadata for sample galleries. We should remove this instance here and leave only the one we already have in the react-birthday/assets
Along the way there we should update the SPFX-VERSION to 1.20.0

@@ -1,58 +1,47 @@
{
"name": "birthdays-anniversary",
"version": "2.0.0",
"name": "happy-birthday",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change the name?

"name": "birthdays-anniversary",
"version": "2.0.0",
"name": "happy-birthday",
"version": "0.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should either not change the version number to make it higher but not smaller

@Adam-it Adam-it marked this pull request as draft October 11, 2024 19:39
@hugoabernier
Copy link
Collaborator

@ValerasNarbutas do you mind taking a look at the code or instructions. The build seems to produce the following error in certain cases:
{
"statusCode": 400,
"code": "invalidRequest",
"requestId": "3dbfa519-574b-41b2-b9e2-42b605801c77",
"date": "2024-10-12T20:43:53.000Z",
"body": "{"code":"invalidRequest","message":"Field 'Birthday' cannot be referenced in filter or orderby as it is not indexed. Provide the 'Prefer: HonorNonIndexedQueriesWarningMayFailRandomly' header to allow this, but be warned that such queries may fail on large lists.","innerError":{"date":"2024-10-12T16:43:53","request-id":"3dbfa519-574b-41b2-b9e2-42b605801c77","client-request-id":"429059bb-c957-5969-ae5a-84515e5d9870"}}"
}

@ValerasNarbutas
Copy link
Contributor Author

@ValerasNarbutas do you mind taking a look at the code or instructions. The build seems to produce the following error in certain cases:
{
"statusCode": 400,
"code": "invalidRequest",
"requestId": "3dbfa519-574b-41b2-b9e2-42b605801c77",
"date": "2024-10-12T20:43:53.000Z",
"body": "{"code":"invalidRequest","message":"Field 'Birthday' cannot be referenced in filter or orderby as it is not indexed. Provide the 'Prefer: HonorNonIndexedQueriesWarningMayFailRandomly' header to allow this, but be warned that such queries may fail on large lists.","innerError":{"date":"2024-10-12T16:43:53","request-id":"3dbfa519-574b-41b2-b9e2-42b605801c77","client-request-id":"429059bb-c957-5969-ae5a-84515e5d9870"}}"
}

Will do @hugoabernier

@ValerasNarbutas
Copy link
Contributor Author

thanks for checking @Adam-it and @hugoabernier , will review this.

@ValerasNarbutas
Copy link
Contributor Author

Birthday

Hey @hugoabernier , did you indexed "Birthday", it is in instructions
image

@hugoabernier hugoabernier marked this pull request as ready for review October 21, 2024 03:56
@hugoabernier hugoabernier merged commit 1b4d25d into pnp:main Oct 21, 2024
2 checks passed
@hugoabernier
Copy link
Collaborator

Many thanks @ValerasNarbutas for your update! Awesome!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Birthdays web part to latest version of SPFx - Refresh Rangers Hacktoberfest Event
3 participants