Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Remove y and mo from join_asof #19027

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

deanm0000
Copy link
Collaborator

Fixes #18955

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (71a8b05) to head (d496dbe).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/_utils/convert.py 25.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19027      +/-   ##
==========================================
- Coverage   79.88%   79.86%   -0.02%     
==========================================
  Files        1522     1524       +2     
  Lines      206958   207753     +795     
  Branches     2906     2910       +4     
==========================================
+ Hits       165322   165924     +602     
- Misses      41088    41278     +190     
- Partials      548      551       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli
Copy link
Collaborator

thanks for looking into this

  • should the validation be done in rust?
  • if month and year are being removed, so should quarter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

join_asof tolerance parameters "mo" and "y" do not work
2 participants