upgrade polkadot to v0.9.22 and integrate jsonrsee #695
Conversation
cargo update -p sp-std --precise 616d33ea23bab86cafffaf116fc607b6790fb4eb
|
Hi! Can I ask what is the progress of this? I need to upgrade my chain to substrate |
|
@dpryde258 I'm on holidays this week, I'll finalize this PR on monday :) |
Sorry for interrupting your holiday. Monday would be great. Thanks a lot for quick response. |
|
We did it too: humanode-network@0433298 |
|
@dpryde258 the code and tests compile now, but some ts integration tests still fail, I'm working on fixing thoses, I hope to finish tonight :) |
client/rpc/src/eth_pubsub.rs
Outdated
| // | ||
| // Only send new notifications down the pipe when the syncing status changed. | ||
| use std::sync::atomic::{AtomicBool, Ordering}; | ||
| let last_syncing_status = |
There was a problem hiding this comment.
Atomics are heavy-weaponry, how about doing something like this instead: humanode-network@e93977a
There was a problem hiding this comment.
Yes, it would work, thanks for the suggestion :)
|
@dpryde258 the PR is finally ready @sorpaas this PR is finally ready for review :) |
|
great work and wait for merge. |
sorpaas
changed the title
|
Yes, tks a lot for dedication @librelois . |
* upgrade substrate to polkadot-v0.9.22 cargo update -p sp-std --precise 616d33ea23bab86cafffaf116fc607b6790fb4eb * replace jsonrpc-* dependencies by jsonrpsee * wip * ref: migrate to jsonrpsee * migrate template to jsonrpsee * fix clippy warnings * fix rust tests * fix manual seal compilation * fmt * Add ethereum style subscription id provider * ref: not use atomic * Use ethereum style subscription id provider in manual-seal mode too * fix manual seal build * fix: subscription id should be prefixed by 0x * for some reason, the extrinsic gas limit change * pin substrate 6c14be4 * fix build
This PR upgrade substrate to polkadot v0.9.22, this requires to integrate jsonrpsee at the same time.