Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clippy and update Rust #299

Merged
merged 11 commits into from
May 17, 2024
Merged

Fix Clippy and update Rust #299

merged 11 commits into from
May 17, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented May 1, 2024 •
edited
Loading

Clippy warnings are now forbidden.

Changes:

  • Update Rust stable and nightly
  • Automatic clippy fix
  • Forbid clippy warnings
  • Remove redundant imports
  • Added minimal amount of allow(s to suppress clippy.
  • Does not require a CHANGELOG entry

[email protected] and others added 4 commits May 1, 2024 17:33
@ggwpez
Run automatic clippy fix
43d79bb 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Forbid clippy warnings
6fdc984 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Remove redundant imports
7185df8 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
fmt
f8282b3 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@seadanda
Copy link
Contributor

seadanda commented May 2, 2024

I just noticed in the last release that they are now built with 1.77, so the versions will need a bump again to keep fmt, clippy and the tests working with the same versions as the releases.
"These runtimes were built with rustc 1.77.0 (aedd173a2 2024-03-17) using srtool v0.15.0"

@ggwpez
Copy link
Member Author

ggwpez commented May 2, 2024

to keep fmt, clippy and the tests working with the same versions

I think fmt and clippy are supposed to run with nightly, since they have a lot of features not present in stable.
Tests should run with stable - yes.

ggwpez added 2 commits May 2, 2024 14:27
@ggwpez
Fix and suppress clippy
2d3a962 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Use correct weights
58fbda2 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@seadanda
Copy link
Contributor

seadanda commented May 2, 2024

By bumping versions I was suggesting to bump stable to 1.77.0 and nightly to (something like) 2024-04-10 from around the same time if we're building with 1.77.

ggwpez added 4 commits May 2, 2024 18:13
@ggwpez
Bump stable to 1.77
587d6a2 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Allow unused migration
eccc4f9 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
More clippy
7095116 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Clippy
f521c64 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez changed the title Fix nightly Clippy Fix Clippy and update Rust May 2, 2024
@github-actions github-actions bot requested a review from bkchr May 15, 2024 12:17
@github-actions GitHub Actions
Copy link

Review required! Latest push from author must always be reviewed

ordian
ordian approved these changes May 16, 2024
View reviewed changes
system-parachains/collectives/collectives-polkadot/src/fellowship/tracks.rs
@@ -80,7 +80,7 @@ const RETAIN_MAX_DECIDING: u32 = 25;
const RETAIN_DECISION_DEPOSIT: Balance = 5 * DOLLARS;
const RETAIN_PREPARE_PERIOD: BlockNumber = 0;
const RETAIN_DECISION_PERIOD: BlockNumber = 14 * DAYS;
const RETAIN_CONFIRM_PERIOD: BlockNumber = 1 * HOURS;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, this seems like a downgrade in readability - can we suppress this lint?

@bkchr
Copy link
Contributor

bkchr commented May 17, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit f29ef4b into main May 17, 2024
41 of 42 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@bkchr bkchr deleted the oty-fix-clippy-nightly branch May 17, 2024 09:02
@rzadp rzadp mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

@ordian ordian ordian approved these changes

@skunert skunert skunert approved these changes

@bkchr bkchr bkchr approved these changes

@acatangiu acatangiu acatangiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ggwpez @seadanda @bkchr @xlc @ordian @skunert @acatangiu